Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI feedback when no result #444

Closed
Don-Isdale opened this issue Dec 4, 2024 · 3 comments
Closed

GUI feedback when no result #444

Don-Isdale opened this issue Dec 4, 2024 · 3 comments
Assignees

Comments

@Don-Isdale
Copy link
Collaborator

This sub-issue is part of #443.


Motivation

The GUI presentation should distinguish between the situation in which a result has not been received, as distinct from a result which is empty.

Blast Search :

  • GUI feedback when no result : 'nothing found', e.g. Blast Search : "no hits"
@Don-Isdale
Copy link
Collaborator Author

Don-Isdale commented Dec 5, 2024

Changes implemented in Genotype Search

Display a count of replies received for Chromosomes, and total number of SNPs in the results for all chromosomes of the dataset.

aac5b89 genotype-search : display result counts

@Don-Isdale
Copy link
Collaborator Author

Don-Isdale commented Dec 6, 2024

Changes implemented in Feature Search

Display a count of Features found; previously this was displayed only when > 0.

fb97d70 Feature Search : GUI feedback when no result

Tested on local

Initial styling; the badge style was not retained.
Screenshot from 2024-12-06 14-28-54

Test with 0 results, i.e. searching for an invalid Feature name :
Screenshot from 2024-12-06 16-58-06

Tests with and without 'Match Aliases' :
Screenshot from 2024-12-06 15-42-33
Screenshot from 2024-12-06 15-42-13

Don-Isdale added a commit that referenced this issue Dec 6, 2024
part of #444 (as was previous commit aac5b89)
goto-feature-list.js : matchAliasesChanged() : set .matchAliases = value, which is now target.checked not event.
manage-genotype.js : vcfGenotypeReceiveResult() : resultCounts : log createdFeatures.length
blast-results-view.js : showTable() : after promise is resolved, don't continue loop waiting for result.

goto-feature-list.hbs :
 <input checkbox matchAliases : pass value='target.checked' to matchAliasesChanged (default arg wasxo event)
 instead of displaying .blocksOfFeatures.length when non-zero, display it when not .loading, and also display .aliases.length
@Don-Isdale
Copy link
Collaborator Author

Tested DNA Sequence ("Blast") Search

This is already implemented in Blast Search.
The following screen-shot shows the test result confirming that a search which results in 0 matches displays the message "The search completed and returned 0 hits" :

Screenshot from 2024-12-06 12-08-35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant