Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test PR #12

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Test PR #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20,331 changes: 682 additions & 19,649 deletions dist/Vxg.common.js
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion dist/Vxg.common.js.map
View file
Open in desktop

This file was deleted.

112 changes: 111 additions & 1 deletion dist/Vxg.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,111 @@
.vxg-icon{padding:20px}.vxg-app-bar{height:64px;background-color:#fff;margin-left:25px}.vxg-head-btn{height:100%;background-color:#fff!important;color:rgb(var(--vxg-ct0));text-transform:none!important;-webkit-box-shadow:none!important;box-shadow:none!important;margin-left:10px}.vxg-head-btn .v-icon{color:rgb(var(--vxg-ci0))!important}.basic-footer[data-v-edc4307a]{padding:1rem;text-align:center;background-color:#f5f5f5;color:#333}nav.vxg-side,nav.vxg-side .v-sheet{background-color:rgb(var(--vxg-cb1))!important}nav.vxg-side .v-divider{border-color:rgb(var(--vxg-ct2))!important;margin:16px 8px}.btn-style{background-color:#283348!important;width:141px;height:281px;margin:4px!important}.btn-style.selected-btn{background-color:rgb(var(--vxg-cb1))!important}.btn-style.selected-btn,.btn-style.selected-btn .v-icon{color:rgb(var(--vxg-ct1))!important}.vxg-toggle{background-color:rgb(var(--vxg-cb1))!important;padding:10px!important;padding-bottom:10px;padding-top:10px;margin-right:10px}a.vxg-router-link{display:block;margin:0 8px;padding:16px 8px;text-decoration:none!important;color:rgb(var(--vxg-ct1))!important;border-radius:8px}a.vxg-router-link .v-icon{color:rgb(var(--vxg-ct2))!important}a.vxg-router-link.router-link-active{background-color:rgb(var(--vxg-cb2))!important;color:rgb(var(--vxg-ct1))!important}a.vxg-router-link.router-link-active .v-icon{color:rgb(var(--vxg-ct1))!important}.vxg-side-open{width:48px;height:48px}.drawer-toggle{width:48px}.font-size-13{font-size:13px}.vxg-form-field{text-align:right;padding:0 8px 0 0;-webkit-box-sizing:border-box;box-sizing:border-box}div.changes{width:100%;color:rgba(0,0,0,.26)!important;background-color:transparent!important}div.changes table{width:100%;background-color:#fff!important;border-bottom:0;border-left:0;border-right:1px solid rgba(0,0,0,.26);border-top:1px solid rgba(0,0,0,.26)}div.changes td,div.changes th{background-color:#fff!important;border-right:0;border-top:0;border-left:1px solid rgba(0,0,0,.26);border-bottom:1px solid rgba(0,0,0,.26);padding:4px}
.vxg-icon {
padding: 20px;
}
.vxg-app-bar {
height: 64px;
background-color: white;
margin-left: 25px;
}
.vxg-head-btn {
height: 100%;
background-color: white !important;
color: rgb(var(--vxg-ct0));
text-transform: none !important;
-webkit-box-shadow: none !important;
box-shadow: none !important;
margin-left: 10px;
}
.vxg-head-btn .v-icon {
color: rgb(var(--vxg-ci0)) !important;
}
.basic-footer[data-v-d93f7088] {
padding: 1rem;
text-align: center;
background-color: #f5f5f5;
color: #333;
}
nav.vxg-side {
background-color: rgb(var(--vxg-cb1)) !important;
}
nav.vxg-side .v-sheet {
background-color: rgb(var(--vxg-cb1)) !important;
}
nav.vxg-side .v-divider {
border-color: rgb(var(--vxg-ct2)) !important;
margin: 16px 8px;
}
.btn-style {
background-color: #283348 !important;
width: 141px;
height: 281px;
margin: 4px !important;
}
.btn-style.selected-btn {
background-color: rgb(var(--vxg-cb1)) !important;
color: rgb(var(--vxg-ct1)) !important;
}
.btn-style.selected-btn .v-icon {
color: rgb(var(--vxg-ct1)) !important;
}
.vxg-toggle {
background-color: rgb(var(--vxg-cb1)) !important;
padding: 10px !important;
padding-bottom: 10px;
padding-top: 10px;
margin-right: 10px;
}
a.vxg-router-link {
display: block;
margin: 0px 8px;
padding: 16px 8px;
text-decoration: none !important;
color: rgb(var(--vxg-ct1)) !important;
border-radius: 8px;
}
a.vxg-router-link .v-icon {
color: rgb(var(--vxg-ct2)) !important;
}
a.vxg-router-link.router-link-active {
background-color: rgb(var(--vxg-cb2)) !important;
color: rgb(var(--vxg-ct1)) !important;
}
a.vxg-router-link.router-link-active .v-icon {
color: rgb(var(--vxg-ct1)) !important;
}
.vxg-side-open {
width: 48px;
height: 48px;
}
.drawer-toggle {
width: 48px;
}
.font-size-13 {
font-size: 13px;
}
.vxg-form-field {
text-align: right;
padding: 0px 8px 0px 0px;
-webkit-box-sizing: border-box;
box-sizing: border-box;
}
div.changes {
width: 100%;
color: rgba(0, 0, 0, 0.26) !important;
background-color: rgba(0, 0, 0, 0) !important;
}
div.changes table {
width: 100%;
background-color: #FFF !important;
border-bottom: 0px;
border-left: 0px;
border-right: 1px solid rgba(0, 0, 0, 0.26);
border-top: 1px solid rgba(0, 0, 0, 0.26);
}
div.changes th, div.changes td {
background-color: #FFF !important;
border-right: 0px;
border-top: 0px;
border-left: 1px solid rgba(0, 0, 0, 0.26);
border-bottom: 1px solid rgba(0, 0, 0, 0.26);
padding: 4px;
}
70 changes: 35 additions & 35 deletions dist/Vxg.umd.js
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion dist/Vxg.umd.js.map
View file
Open in desktop

This file was deleted.

1,071 changes: 1,061 additions & 10 deletions dist/Vxg.umd.min.js
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion dist/Vxg.umd.min.js.map
View file
Open in desktop

This file was deleted.

3 changes: 2 additions & 1 deletion example/basic/src/store/store.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ function makeStore(Vue) {
add: 0
},
search: {
term: ''
a: '',
b: ''
Comment on lines +35 to +36
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Improve State Property Names for Clarity

The properties a and b in the search state may not clearly convey their purpose. Descriptive names enhance code readability and maintainability.

Apply this diff to rename the properties:

-  a: '',
-  b: ''
+  searchPoint: '',
+  searchDestination: ''
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
a: '',
b: ''
searchPoint: '',
searchDestination: ''

},
},

Expand Down
9 changes: 7 additions & 2 deletions src/components/BasicHead.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ export default {


watch: {
'$store.state.trigger.search.term' (term) {
'$store.state.trigger.search.a' (term) {
if(term == '' && this.$refs.search) {
this.$refs.search.reset()
// this.tag_items = this.items.map(v => v.tag)
Expand All @@ -275,7 +275,7 @@ export default {
// term = m[1].trim()
// }
// this.$store.dispatch('trigger_search', {term:this.search})
this.$store.dispatch('trigger_search', {term})
this.$store.dispatch('trigger_search', {a: term})
},
select () {
this.$store.dispatch('trigger_select', {value:this.select})
Expand Down Expand Up @@ -367,6 +367,7 @@ export default {
let out = await this.$seneca.post('sys:search, cmd:search',
{ query: term, params: this.search_config }
)
console.log('Search result:', out);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Remove Console Logs in Production Code

While console.log statements are helpful during development, it's best to remove them in production to keep the console clean.

Apply this diff to remove the console log:

-console.log('Search result:', out);

// this.tag_items = out.data.hits.map(v => v.id)
this.tag_items = out.data.hits.map(v=>tag_alias(v.doc))
}
Expand All @@ -378,6 +379,10 @@ export default {
}, 11)

},
tag_alias(item) {
// Define your tag_alias function here
return item.tag; // Example implementation
},
Comment on lines +382 to +385
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Avoid Duplicate tag_alias Functions

The tag_alias function is defined in both BasicHead.vue and BasicSide.vue. To promote reusability and maintain consistency, consider moving this function to a shared utility module.


filterAssets () {
this.$store.dispatch('vxg_trigger_go')
Expand Down
Loading
Loading