Running into an error where PyTorch is using #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
higher and higher SIGNAL codes…. I think this could be fixed by updating the replace_signal to take in additional codes
|
@mmaloney007 thank you for the PR! Would you mind updating the title to make it a bit more clear and show in the description an example of the sort of undesirable behavior that the current implementation would give rise to that your implementation would fix? |
|
Bump @mmaloney007 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
higher and higher SIGNAL codes…. I think this
could be fixed by updating the replace_signal
to take in additional codes