Repository navigation
fix(deps): resolve portal vulnerabilities and fix the controller build - #732
Merged
Merged
Conversation
## Summary Resolves the fixable `npm audit` findings and Dependabot alerts in `portal/`. `package.json` is unchanged; only the lockfile moves. ## Angular (re-resolved within the existing `^22.0.0` ranges) - @angular/common, compiler, compiler-cli, core, forms, platform-browser, router 22.1.3 → 22.2.3 (@angular/router GHSA-ff3f-86qr-9cv3, GHSA-62vg-58rm) - @angular/build, @angular/cli 22.1.5 → 22.2.4; this brings piscina 5.2.0 → 5.3.2 (critical, GHSA-67c8-pqhq-4rmx) and replaces @modelcontextprotocol/sdk 1.30.0 with @modelcontextprotocol/server 2.3.1, which also drops hono, ip-address and proxy-addr ## Lockfile updates (`npm audit fix`) - vite 8.2.2 → 8.3.5, fast-uri 3.1.6 → 3.1.9, follow-redirects 1.16.0 → 1.16.1, source-map-js 1.2.1 → 1.2.2, brace-expansion 5.0.9 → 5.0.12, engine.io 6.6.9 → 6.6.11, qs 6.15.3 → 6.16.1 ## Not fixable - braces 3.0.3 (GHSA-vfj7-8cjw-p6xm), dev only, via karma/chokidar; no patched version is published ## Verification `npm ci`, `npm install` and `npm run build` pass (the CI and `deploy/portal.Dockerfile` steps). The portal has no tests (no spec files) and CI does not run `ng test`. `ng test` itself fails at startup on main as well (`Cannot assign to read only property 'describe'`, zone.js with jasmine-core 7 since platform-mesh#697). On-behalf-of: @SAP grzegorz.krajniak@sap.com Signed-off-by: gkrajniak <gkrajniak@gmail.com>
…pports 0.25 ## Why The controller image has not built since platform-mesh#705 moved sigs.k8s.io/controller-runtime to 0.25 (and k8s.io/client-go to 0.37): github.com/kcp-dev/multicluster-provider v0.8.0, its latest release (and its main branch), is built against controller-runtime 0.24, and `go build ./cmd/wild-west/...` fails with `*ScopedCluster does not implement cluster.Cluster (wrong type for method GetEventRecorder)`. The last successful build of the images on main was platform-mesh#698 (2026-08-31). ## What changed - sigs.k8s.io/controller-runtime, sigs.k8s.io/multicluster-runtime v0.25.2 → v0.24.1 (the versions multicluster-provider v0.8.0 requires) - k8s.io/api, k8s.io/apimachinery, k8s.io/client-go v0.37.1 → v0.36.5, k8s.io/apiextensions-apiserver v0.37.0 → v0.36.5 (controller-runtime 0.24 and kcp-dev/sdk v0.33.1 require 0.36) - `renovate.json`: holds controller-runtime and multicluster-runtime below 0.25 and the k8s.io modules below 0.37, so Renovate does not re-introduce the break; remove the rules once multicluster-provider releases a version built against controller-runtime 0.25 ## Verification `go build` of `./cmd/wild-west/...`, `./cmd/init/...` and `./cmd/armament-sync/...` (also for linux/amd64 and linux/arm64, as in the Dockerfiles) and `go vet ./...` pass; the module has no Go tests. Only the six modules above change in the compiled build list, and `govulncheck` reports no vulnerabilities outside the Go standard library. `renovate-config-validator` accepts `renovate.json`. On-behalf-of: @SAP grzegorz.krajniak@sap.com Signed-off-by: gkrajniak <gkrajniak@gmail.com>
ntnn
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the fixable
npm auditfindings and Dependabot alerts inportal/.package.jsonis unchanged; only the lockfile moves.Angular (re-resolved within the existing
^22.0.0ranges)platform-browser, router 22.1.3 → 22.2.3 (@angular/router
GHSA-ff3f-86qr-9cv3, GHSA-62vg-58rm)
5.2.0 → 5.3.2 (critical, GHSA-67c8-pqhq-4rmx) and replaces
@modelcontextprotocol/sdk 1.30.0 with @modelcontextprotocol/server
2.3.1, which also drops hono, ip-address and proxy-addr
Lockfile updates (
npm audit fix)1.16.1, source-map-js 1.2.1 → 1.2.2, brace-expansion 5.0.9 → 5.0.12,
engine.io 6.6.9 → 6.6.11, qs 6.15.3 → 6.16.1
Not fixable
patched version is published
Verification
npm ci,npm installandnpm run buildpass (the CI anddeploy/portal.Dockerfilesteps). The portal has no tests (no specfiles) and CI does not run
ng test.ng testitself fails at startupon main as well (
Cannot assign to read only property 'describe',zone.js with jasmine-core 7 since #697).
Controller build (pinned Go dependencies)
Why
The controller image has not built since #705 moved
sigs.k8s.io/controller-runtime to 0.25 (and k8s.io/client-go to 0.37):
github.com/kcp-dev/multicluster-provider v0.8.0, its latest release
(and its main branch), is built against controller-runtime 0.24, and
go build ./cmd/wild-west/...fails with*ScopedCluster does not implement cluster.Cluster (wrong type for method GetEventRecorder). The last successful build of the images onmain was #698 (2026-08-31).
What changed
v0.25.2 → v0.24.1 (the versions multicluster-provider v0.8.0 requires)
k8s.io/apiextensions-apiserver v0.37.0 → v0.36.5 (controller-runtime
0.24 and kcp-dev/sdk v0.33.1 require 0.36)
renovate.json: holds controller-runtime and multicluster-runtimebelow 0.25 and the k8s.io modules below 0.37, so Renovate does not
re-introduce the break; remove the rules once multicluster-provider
releases a version built against controller-runtime 0.25
Verification
go buildof./cmd/wild-west/...,./cmd/init/...and./cmd/armament-sync/...(also for linux/amd64 and linux/arm64, as inthe Dockerfiles) and
go vet ./...pass; the module has no Go tests.Only the six modules above change in the compiled build list, and
govulncheckreports no vulnerabilities outside the Go standardlibrary.
renovate-config-validatoracceptsrenovate.json.