feat: adding global and element level hooks #55
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattalline
force-pushed
the
adding-hooks
branch
from
979fe14 to
672ea1c
Compare
mattalline
commented
Oct 21, 2025
Comment on lines
+214
to
+215
| let seenInGlobal: any = null | ||
| let seenInLocal: any = null |
There was a problem hiding this comment.
I originally tried to have some types here but the current typescheck target was failing on the assertions below.
|
Closing this given it seems like this repo doesn't get much attention. Will explore forks or other methods of extending this elsewhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the discussion in #32 I thought it may be worth actually exploring hooks that allow someone to perform anything they needed before a tool / resource / etc. are invoked instead of just auth concerns. Currently this draft PR is a bit more of a concrete example of what I was thinking rather than trying to put it into words for the thread linked above on the issue.
Items to implement
Other Concerns