Make Plausible.ce? and Plausible.ee? into functions (#4158)

* make Plausible.ce? and Plausible.ee? into functions * Fix phash and predicate order to make dialyzer trick working again --------- Co-authored-by: Adrian Gruntkowski <[email protected]>
plausible · May 29, 2024 · 55dfe4c · 55dfe4c
1 parent 7934973
commit 55dfe4c
Showing 1 changed file with 6 additions and 15 deletions.
diff --git a/lib/plausible.ex b/lib/plausible.ex
@@ -20,23 +20,14 @@ defmodule Plausible do
     do_on_ce(clauses)
   end
 
-  defmacro ee?() do
-    ee? = Mix.env() not in @ce_builds
+  # :erlang.phash2(1, 1) == 0 tricks dialyzer as per:
+  # https://github.com/elixir-lang/elixir/blob/v1.12.3/lib/elixir/lib/gen_server.ex#L771-L778
 
-    # Tricking dialyzer as per:
-    # https://github.com/elixir-lang/elixir/blob/v1.12.3/lib/elixir/lib/gen_server.ex#L771-L778
-    quote do
-      :erlang.phash2(1, 1) == 0 and unquote(ee?)
-    end
-  end
-
-  defmacro ce?() do
-    ce_build? = Mix.env() in @ce_builds
+  ee? = Mix.env() not in @ce_builds
+  def ee?, do: :erlang.phash2(1, 1) == 0 and unquote(ee?)
 
-    quote do
-      unquote(ce_build?)
-    end
-  end
+  ce? = Mix.env() in @ce_builds
+  def ce?, do: :erlang.phash2(1, 1) == 0 and unquote(ce?)
 
   defp do_on_ce(do: block) do
     do_on_ee(do: nil, else: block)