Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't log migrations in tests #3896

Closed
wants to merge 1 commit into from
Closed

Conversation

ruslandoga
Copy link
Contributor

@ruslandoga ruslandoga commented Mar 15, 2024

Changes

When tests fail in GitHub actions, I need to scroll through the migrations output to see the failure reason. This PR tries to make seeing the failure reason easier.

I expect the data migration output to still be logged, so there is another approach with running migrations in a separate step: #3897

Tests

  • This PR does not require tests

Changelog

  • This PR does not make a user-facing change

Documentation

  • This change does not need a documentation update

Dark mode

  • This PR does not change the UI

@ruslandoga
Copy link
Contributor Author

Closing in favor of #3897 since non-Ecto migrations still get logged.

@ruslandoga ruslandoga closed this Mar 15, 2024
@ruslandoga ruslandoga deleted the no-log-test-migrations branch March 19, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant