Make React frontend capable of reading API results under a results key #4159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertJoonas
added
deploy-to-staging
RobertJoonas
commented
May 29, 2024
Comment on lines
-14
to
15
| return api.get(apiPath(site, '/countries'), query, {limit: 9}).then((res) => { | ||
| return res.map(row => Object.assign({}, row, {percentage: undefined})) | ||
| }) | ||
| return api.get(apiPath(site, '/countries'), query, { limit: 9 }) | ||
| } |
There was a problem hiding this comment.
I believe this manual mapping to percentage undefined was used in order to prevent displaying percentages in this view:
However, the ListReport component does not render it anyway unless it's specified in the metrics prop, so the outcome is essentially the same without this manual mapping.
zoldar
reviewed
May 29, 2024
add length key back Co-authored-by: Adrian Gruntkowski <[email protected]>
zoldar
approved these changes
May 29, 2024
ukutaht
approved these changes
May 30, 2024
Yes, @ukutaht. The PR that implements filtering will remove it so we'll start relying only on the results key. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
With the new imported data filtering feature, we'll start returning warnings in the dashboard API results, which means we'll need to move the actual list of results under a separate
resultskey.This PR is a preparation in order to not break the frontend when suddenly receiving API results under a
resultskey. For some time, we'll need to be able to handle both a straight-up list response, or a map, containing theresultskey.Tests
Changelog
Documentation
Dark mode