Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix registration in ce #4165

Merged
merged 1 commit into from
Jun 3, 2024
Merged

fix registration in ce #4165

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/plausible_web/live/register_form.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ defmodule PlausibleWeb.Live.RegisterForm do

{:noreply, push_event(socket, "send-metrics", metrics_params)}
else
{:noreply, socket}
{:noreply, assign(socket, trigger_submit: true)}
Copy link
Contributor Author

@ruslandoga ruslandoga May 30, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In CE Metrics hook isn't used so "send-metrics-after" event (which triggers submit) never arrives.

end

{:error, changeset} ->
Expand Down