-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple filters on the frontend #4174
+1,020
−503
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
ebba857
Add new logic for query parsing
macobo 649e2b4
Send filters to BE in new encoding, flag add more button
macobo eecca3f
query.property -> query.dimensions
macobo 4c8619a
Reduce number of operations for filtering
macobo 00bfbc3
Update search console filter mapping
macobo ebdc4d6
Update filters sent from frontend
macobo 29622a6
Update new filter parsing
macobo 5aea148
Remove redundant clause
macobo 77bc58d
Make filtering by event:goal work
macobo 5cce800
Handle * as old backend did - prefix/suffix by **, if not using wildc…
macobo 1c88350
Update imports logic
macobo 849ce4f
Credo warning
macobo 1387b42
Spacing for add row button in filter modals
ukutaht 1506337
query fix
macobo 4b5fbf0
LegacyDashboardFilterParser
macobo 72b7ce1
only single hostname filter allowed
macobo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to go in the direction that
matches
is a first-class operation that would also be available in the API. Am I reading it right?My thinking on what filters should be available to client:
is
- can deal with lists like you've already done in this PR. Can also take wildcards.contains
- equivalent tois
where value is wrapped with*${value}*
I'm not sure about exposing
matches
for simple wildcards. It would fit better for a full regex match filter operation in the future.WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I completely understood. Created https://3.basecamp.com/5308029/buckets/37310803/card_tables/cards/7494308360 for this discussion so it doesn't get dropped.