Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APIv2: Aggregates, timeseries, conversion_rate, hostname #4251

Merged
merged 38 commits into from
Jun 28, 2024
Merged

APIv2: Aggregates, timeseries, conversion_rate, hostname #4251

merged 38 commits into from
Jun 28, 2024

Conversation

macobo
Copy link
Contributor

@macobo macobo commented Jun 20, 2024 •
edited
Loading

Changes

  • Aggregates now use new QueryBuilder
  • Limited timeseries support in APIv2 - everything works, but results are only returned in bucket they're active in
  • conversion_rate and group_conversion_rate metrics support
  • Imports-related changes to support apiv2 - next PR will re-simplify
  • Goals are preloaded into Query object for validation purposes
  • event:goal breakdowns support. Now a single query and system is more flexible for renaming goals.
  • event:page breakdows support. QueryOptimizer.split now splits query to two - sessions query uses visit:entry page
  • fixed the memory leak around event:props:x creating symbols

ukutaht
ukutaht reviewed Jun 20, 2024
View reviewed changes
lib/plausible/stats/filters/query_parser.ex Outdated Show resolved Hide resolved
lib/plausible/stats/filters/query_parser.ex Outdated Show resolved Hide resolved
lib/plausible/stats/filters/query_parser.ex Outdated Show resolved Hide resolved
lib/plausible/stats/filters/query_parser.ex Outdated Show resolved Hide resolved
lib/plausible/stats/filters/query_parser.ex Show resolved Hide resolved
lib/plausible/stats/filters/query_parser.ex Show resolved Hide resolved
test/plausible_web/controllers/api/external_stats_controller/query_test.exs Outdated Show resolved Hide resolved
lib/plausible/stats/filters/query_parser.ex Outdated Show resolved Hide resolved
lib/plausible/stats/sql/query_builder.ex Outdated Show resolved Hide resolved
Base automatically changed from external-stats-new-querying to master June 25, 2024 06:28
@macobo macobo marked this pull request as ready for review June 25, 2024 06:30
macobo added 26 commits June 27, 2024 10:00
@macobo
Add some aggregates tests
a4654ff
@macobo
Port aggregates tests to do with filtering
b251dd3
@macobo
Session metrics can be queried with event: filters
62501c2
@macobo
Solve a typo
0a16fdd
@macobo
Update a validation message
2070689
@macobo
Add validations for views_per_visit
010f382
@macobo
Port an aggregation/imports test
3949858
@macobo
Optimize time dimension, add tests
054d2d0
@macobo
Add first timeseries test, update parsing tests
f2603ed
@macobo
Docs for SQL.Expression
9fcfbb6
@macobo
Test timeseries more
db87d1b
@macobo
Allow time explicitly in order_by
2219cd0
@macobo
Add multiple breakdowns test
a012f6e
@macobo
Refactor QueryOptimizer not to care about time dimension placement in…
017bb0d 
… dimensions array
@macobo
Add test breaking down by event:hostname
64eadf7
@macobo
Add hostname filtering logic to QueryOptimizer, unblock some tests
de6a0b0
@macobo
WIP: Breakdown by goal
7863282
@macobo
conversion rate logic for query api
dc277a7
@macobo
Update more tests
3081a79
@macobo
Set default order_by
84bda8f
@macobo
dimension_label
ead57d9
@macobo
preloaded_goals in tests
89a4a5f
@macobo
inline load_goals
db18209
@macobo
Use Date functions over Timex
8e4bf88
@macobo
Comments
18c8287
@macobo
is_binary
f004899
@macobo macobo mentioned this pull request Jun 27, 2024
Open
@macobo macobo added the deploy-to-staging Special label that triggers a deploy to a staging environment label Jun 27, 2024
@macobo macobo merged commit 2eeaf7a into master Jun 28, 2024
13 checks passed
@macobo macobo deleted the apiv2-aggregates-tests branch June 28, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ukutaht ukutaht ukutaht approved these changes

Assignees
No one assigned
Labels
deploy-to-staging Special label that triggers a deploy to a staging environment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@macobo @ukutaht