Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APIv2: Replace breakdown module with QueryBuilder #4283

Merged
merged 45 commits into from
Jul 1, 2024
Merged

APIv2: Replace breakdown module with QueryBuilder #4283

merged 45 commits into from
Jul 1, 2024

Commits on Jun 28, 2024

  1. WIP: Breakdown using QueryBuilder

    @macobo
    macobo committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    719a800 View commit details
    Browse the repository at this point in the history

  2. Revert "Remove problematic test" 

    This reverts commit b442bb5.
    @macobo
    macobo committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    c2d235e View commit details
    Browse the repository at this point in the history

  3. Get more breakdown tests passing

    @macobo
    macobo committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    2826624 View commit details
    Browse the repository at this point in the history

  4. Preload goals, sort when dealing with time_on_page

    @macobo
    macobo committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    3fe8155 View commit details
    Browse the repository at this point in the history

  5. Handle conversion_rate in breakdowns

    @macobo
    macobo committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    4aa91db View commit details
    Browse the repository at this point in the history

  6. Simplify ordering by using selected_as consistently for dimensions

    @macobo
    macobo committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    774fe43 View commit details
    Browse the repository at this point in the history

  7. Get breakdown tests passing

    @macobo
    macobo committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    2e00452 View commit details
    Browse the repository at this point in the history

  8. Strings to atoms in keys for StatsController.transform_keys calls to … 

    …work
    @macobo
    macobo committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    c461788 View commit details
    Browse the repository at this point in the history

  9. Handle revenue metrics removal

    @macobo
    macobo committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    8e026fa View commit details
    Browse the repository at this point in the history

  10. Add test for nil-removal case

    @macobo
    macobo committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    7c80afa View commit details
    Browse the repository at this point in the history

  11. Include percentage metric

    @macobo
    macobo committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    29908e0 View commit details
    Browse the repository at this point in the history

  12. Fix and test with imported locations

    @macobo
    macobo committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    6422ad5 View commit details
    Browse the repository at this point in the history

  13. Fixup time-on-page

    @macobo
    macobo committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    3e1bb3e View commit details
    Browse the repository at this point in the history

  14. Fix country/region automatic filters

    @macobo
    macobo committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    91138e2 View commit details
    Browse the repository at this point in the history

  15. Handle multiple imports (os/browser version) in importsv2

    @macobo
    macobo committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    f23d8c0 View commit details
    Browse the repository at this point in the history

  16. Filter goals

    @macobo
    macobo committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    44be971 View commit details
    Browse the repository at this point in the history

  17. Default to ordering by page as well

    @macobo
    macobo committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    411abb3 View commit details
    Browse the repository at this point in the history

  18. Calculate conversion rate on sessions if needed

    @macobo
    macobo committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    e6e033b View commit details
    Browse the repository at this point in the history

  19. Order by event dimensions - handles event:page special case

    @macobo
    macobo committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    18f5e20 View commit details
    Browse the repository at this point in the history

  20. Update tests

    @macobo
    macobo committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    eec2093 View commit details
    Browse the repository at this point in the history

  21. Update more tests, handle goal=0 case in imports

    @macobo
    macobo committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    3cd2613 View commit details
    Browse the repository at this point in the history

  22. Handle event:goal breakdowns correctly with filters

    @macobo
    macobo committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    f53a95f View commit details
    Browse the repository at this point in the history

  23. Revenue to money

    @macobo
    macobo committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    03d29fe View commit details
    Browse the repository at this point in the history

  24. Improved table deciding

    @macobo
    macobo committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    4b17275 View commit details
    Browse the repository at this point in the history

  25. Also update event:page filters on event:page breakdown

    @macobo
    macobo committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    a61cceb View commit details
    Browse the repository at this point in the history

  26. bounce_rate to 0 

    Previous behavior relied on two queries being made - new query leads to 0 naturally
    @macobo
    macobo committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    08a2a5c View commit details
    Browse the repository at this point in the history

  27. Update pagination test

    @macobo
    macobo committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    d464cfd View commit details
    Browse the repository at this point in the history

  28. dont count non-pageviews as path goal completions

    @macobo
    macobo committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    d25fc3b View commit details
    Browse the repository at this point in the history

  29. Make revenue logic breakdown-specific 

    Its hard to fit into the new schema and likely needs a rethink for apiv2
    @macobo
    macobo committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    0b38f12 View commit details
    Browse the repository at this point in the history

  30. Retain previous behavior for TimeSeries module

    @macobo
    macobo committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    a0bef27 View commit details
    Browse the repository at this point in the history

  31. Get GA4 test passing 

    Most failures are related to ordering, pageviews shouldnt be read off of sessions
    @macobo
    macobo committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    7e3c940 View commit details
    Browse the repository at this point in the history

  32. Clean up old methods

    @macobo
    macobo committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    f402f66 View commit details
    Browse the repository at this point in the history

  33. Simplify imported.ex

    @macobo
    macobo committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    a1a1d10 View commit details
    Browse the repository at this point in the history

  34. Dont crash on garbage filters

    @macobo
    macobo committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    98dd4c2 View commit details
    Browse the repository at this point in the history

  35. Reflect ordering-related change in test

    @macobo
    macobo committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    f27010c View commit details
    Browse the repository at this point in the history

  36. Fix test data

    @macobo
    macobo committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    34025d9 View commit details
    Browse the repository at this point in the history

  37. Update table_decider

    @macobo
    macobo committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    1b5b00b View commit details
    Browse the repository at this point in the history

  38. Re-simplify get_revenue_tracking_currency

    @macobo
    macobo committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    bbab7a1 View commit details
    Browse the repository at this point in the history

  39. Revert revenue changes

    @macobo
    macobo committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    d9a7de5 View commit details
    Browse the repository at this point in the history

  40. Use Query.set

    @macobo
    macobo committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    6372eec View commit details
    Browse the repository at this point in the history

  41. Remove a TODO

    @macobo
    macobo committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    f8b0765 View commit details
    Browse the repository at this point in the history

  42. csv importer: no pageviews 

    Pageviews were incorrectly fetched from sessions table before, causing issues
    @macobo
    macobo committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    43480c4 View commit details
    Browse the repository at this point in the history

  43. csv importer tweaking

    @macobo
    macobo committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    64a6472 View commit details
    Browse the repository at this point in the history

  44. Remove use Plausible

    @macobo
    macobo committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    7abac8e View commit details
    Browse the repository at this point in the history

  45. to_existing_atom

    @macobo
    macobo committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    eac23c8 View commit details
    Browse the repository at this point in the history