APIv2: macros, SQL cleanup #4286
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macobo
force-pushed
the
apiv2-breakdown-module-remove
branch
from
139e3ee
to
eac23c8
Compare
macobo
force-pushed
the
select_merge_as
branch
2 times, most recently
from
48aef7e
to
9c8d16f
Compare
This simplifies some select_merge calls
ukutaht
approved these changes
Jul 2, 2024
| iex> wrap_expression([t], %{ foo: t.column }) |> expand_macro_once | ||
| "%{foo: dynamic([t], selected_as(t.column, :foo))}" | ||
| """ | ||
| defmacro wrap_expression(binding, map_literal) do |
There was a problem hiding this comment.
I like this macro but the name feels quite generic. Can we come up with something better? My proposals would be with_alias, with_selected_as, wrap_alias or something along these lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup PR.
QueryBuilder requires selected fields to be aliased via both field names passed to
select_mergeas well as settingselected_as. This PR introduces utility macros to reduce this sort of boilerplate.It also moves more code under Plausible.Stats.SQL