Refactor Sites and Stats API authorization logic #4297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoldar
force-pushed
the
sites-stats-api-fallback
branch
2 times, most recently
from
8433332
to
e0a661d
Compare
zoldar
force-pushed
the
sites-stats-api-fallback
branch
from
e0a661d
to
ffc505d
Compare
zoldar
force-pushed
the
sites-stats-api-fallback
branch
from
c9da41e
to
032e567
Compare
zoldar
added
deploy-to-staging
|
1 similar comment
|
aerosol
reviewed
Jul 2, 2024
| defp check_api_key_rate_limit(api_key) do | ||
| case RateLimit.check_rate( | ||
| "api_request:#{api_key.id}", | ||
| to_timeout(hour: 1), |
Co-authored-by: hq1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR refactors authorization logic for Sites and Stats APIs, unifying it under a single plug. API keys already have a notion of "scopes" though it's merely utilized in a label-like fashion for Sites API key checks. The refactored version implements basic support for scopes. Due to the way API keys are currently provisioned (with a single explicit scope at a time), a notion of implicit scopes is introduced, which are considered as always matching provided the API key is valid.
The main point of this refactor is exposing read-only portion of Sites API to API keys without site provisioning scope. It also will serve as a basis for introducing further Sites API read-only endpoints needed for integrations we are currently working on.
Tests
Changelog
Documentation
Dark mode