APIv2: TimeSeries using QueryBuilder, release experimental_session_count
#4305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies some select_merge calls
Note that the previous implementation of the labels from TimeSeries.ex was broken
This becomes required as we try to include visits from sessions by default
macobo
force-pushed
the
apiv2-timeseries-removal
branch
from
00360a7
to
54310b2
Compare
macobo
force-pushed
the
apiv2-timeseries-removal
branch
2 times, most recently
from
2cce337
to
d704b5b
Compare
macobo
force-pushed
the
apiv2-timeseries-removal
branch
from
d704b5b
to
3ed9b90
Compare
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR continues work on APIv2, changing TimeSeries module to use QueryBuilder under the hood. This simplifies operations significantly.
In addition:
include.time_labelsoption is added which includes the time range labels undermeta.time_labels. This is useful when constructing a graph from the time series data.experimental_session_countwhich includes all sessions active in a time range and for hourly/minute graphs smears them across all time buckets they were active in.