Fix debounce #4349
Merged
Fix debounce #4349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertJoonas
force-pushed
the
fix-debounce
branch
from
0541941
to
f688787
Compare
|
4 tasks
RobertJoonas
requested review from
apata and
ukutaht
and removed request for
ukutaht and
apata
RobertJoonas
force-pushed
the
fix-debounce
branch
3 times, most recently
from
dc1732b
to
79b14e3
Compare
This commit refactors the debouncing mechanism in a more extendable way. Using debounce as a hook that returns a callback (rather than an effect) makes it reusable for Combobox. This way the useDebounce hook does not need to worry about whether the function should be called on the first render or not. This commit also gets rid of redundant doubled search state.
RobertJoonas
force-pushed
the
fix-debounce
branch
from
79b14e3
to
285d1e2
Compare
RobertJoonas
force-pushed
the
fix-debounce
branch
from
285d1e2
to
346ddcd
Compare
apata
reviewed
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
A new, cleaner version of #4331 with the review comments addressed.
Tests
Changelog
Documentation
Dark mode