Updated ESLint config and added eslintignore

playcanvas · Aug 13, 2024 · 3da58ff · 3da58ff
1 parent b544667
commit 3da58ff
Show file tree

Hide file tree

Showing 7 changed files with 20 additions and 30 deletions.
diff --git a/.eslintignore b/.eslintignore
@@ -0,0 +1,2 @@
+/dist
+/test
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -15,23 +15,10 @@
     },
     "rules": {
         "accessor-pairs": ["error", { "setWithoutGet": false, "getWithoutSet": false }],
-        "curly": ["error", "multi-line"],
-        "import/order": ["error", {
-          "groups": ["builtin", "external", "internal", ["parent", "sibling"], "index", "unknown"],
-          "newlines-between": "always",
-          "alphabetize": { "order": "asc", "caseInsensitive": true }
-        }],
-        "indent": ["error", 4, {
-          "FunctionExpression": { "body": 1, "parameters": 2 },
-          "MemberExpression": 0,
-          "SwitchCase": 1
-        }],
         "jsdoc/check-tag-names": ["error", { "definedTags": ["category"] }],
         "jsdoc/check-examples": "off",
         "no-prototype-builtins": "off",
         "no-use-before-define": "off",
-        "prefer-arrow-callback": ["error", { "allowNamedFunctions": true }],
-        "prefer-template": "error",
         "require-atomic-updates": "warn"
     }
 }
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -31,7 +31,7 @@
     "@babel/core": "^7.23.7",
     "@babel/eslint-parser": "^7.23.3",
     "@babel/preset-env": "^7.23.8",
-    "@playcanvas/eslint-config": "^1.7.1",
+    "@playcanvas/eslint-config": "^1.7.4",
     "@playcanvas/observer": "1.3.2",
     "@rollup/plugin-babel": "^6.0.4",
     "@rollup/plugin-commonjs": "^26.0.1",

diff --git a/src/assets.js b/src/assets.js
@@ -287,7 +287,7 @@ class Assets extends Events {
             api.realtime.assets.unload(asset.get('uniqueId'));
         }
 
-        this.emit(`remove`, asset);
+        this.emit('remove', asset);
         this.emit(`remove[${asset.get('id')}]`);
     }
 
@@ -689,16 +689,16 @@ class Assets extends Events {
         return this.createJson({
             name: options.name,
             json: options.localizationData || {
-                "header": {
-                    "version": 1
+                'header': {
+                    'version': 1
                 },
-                "data": [{
-                    "info": {
-                        "locale": "en-US"
+                'data': [{
+                    'info': {
+                        'locale': 'en-US'
                     },
-                    "messages": {
-                        "key": "Single key translation",
-                        "key plural": ["One key translation", "Translation for {number} keys"]
+                    'messages': {
+                        'key': 'Single key translation',
+                        'key plural': ['One key translation', 'Translation for {number} keys']
                     }
                 }]
             },

diff --git a/src/entities/references.js b/src/entities/references.js
@@ -65,7 +65,7 @@ function findReferencesInComponents(entity, refType) {
 
             // get script attributes
             if (!api.hasLegacyScripts && api.assets && component === 'script') {
-                const scriptComponent = entity.get(`components.script`);
+                const scriptComponent = entity.get('components.script');
                 for (const scriptName in scriptComponent.scripts) {
                     // get script asset
                     const scriptAsset = api.assets.getAssetForScript(scriptName);

diff --git a/src/schema/settings.js b/src/schema/settings.js
@@ -1,4 +1,4 @@
-import { utils } from "../utils.js";
+import { utils } from '../utils.js';
 
 /**
  * Provides methods to access the settings schema