Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates ESM boilerplate #72

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Updates ESM boilerplate #72

merged 1 commit into from
Apr 12, 2024

Conversation

marklundin
Copy link
Member

Updating the editor-api ESM boiler plate to include new attributes over attributesDefinition, using Script over ScriptType. Also bumping to .31 patch as an earlier release was published with no updates

@marklundin marklundin requested a review from a team April 11, 2024 14:21
@marklundin marklundin changed the title Updates esm boilerplate Updates ESM boilerplate Apr 11, 2024
@Maksims
Copy link
Collaborator

Maksims commented Apr 11, 2024

By dropping scriptName, will that result in name to be equal to actual class name, which will result in Editor parsing not to be camelCase? Which then can result in lines like that: entity.script.Rotator - which is not within our recommended coding style, or really any JS common style.

@marklundin
Copy link
Member Author

marklundin commented Apr 12, 2024

No it's currently lowercase, but can be overridden using static name. if it needs to be camelCase this is more of an editor/engine concern

@marklundin marklundin merged commit 4cb88f7 into main Apr 12, 2024
2 checks passed
@marklundin marklundin deleted the esm-boilerplate-update branch April 12, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants