Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type updates #83

Merged
merged 12 commits into from
Jan 16, 2025
Merged

Type updates #83

merged 12 commits into from
Jan 16, 2025

Conversation

kpal81xd
Copy link
Contributor

@kpal81xd kpal81xd commented Jan 16, 2025 •
edited
Loading

  • Converts JSDoc to TSDoc
  • Removes types from set/get (inferred)
  • Converted initializeHistory to public as referenced in assets.ts
  • Exposed _entities and _assets under public raw field
  • Exposed _observer under observer field

@kpal81xd kpal81xd changed the title Types TSDoc fixup Jan 16, 2025
@kpal81xd kpal81xd self-assigned this Jan 16, 2025
@kpal81xd kpal81xd requested a review from willeastcott January 16, 2025 10:45
@kpal81xd kpal81xd changed the title TSDoc fixup Type updates Jan 16, 2025
@kpal81xd kpal81xd merged commit 39c28c4 into main Jan 16, 2025
2 checks passed
@kpal81xd kpal81xd deleted the types branch January 16, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

Assignees

@kpal81xd kpal81xd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kpal81xd @willeastcott