fix light change type

playcanvas · Jul 30, 2015 · 9decc7c · 9decc7c
1 parent 5c66bb7
commit 9decc7c
Showing 1 changed file with 12 additions and 1 deletion.
diff --git a/src/framework/components/light/light_system.js b/src/framework/components/light/light_system.js
@@ -72,6 +72,7 @@ pc.extend(pc, function () {
             var light = new pc.Light();
             light.setType(lightTypes[data.type]);
             light._node = component.entity;
+            light._scene = this.app.scene;
             this.app.scene.addLight(light);
             component.data.light = light;
 
@@ -107,7 +108,17 @@ pc.extend(pc, function () {
         },
 
         changeType: function (component, oldValue, newValue) {
-            component.light.setType(lightTypes[newValue]);
+            // remove old light
+            this.app.scene.removeLight(component.light);
+            // create new light
+            var light = new pc.Light();
+            light.setType(lightTypes[newValue]);
+            light._node = component.entity;
+            // add to scene
+            this.app.scene.addLight(light);
+            // add to component
+            component.light = light;
+            component.data.light = light;
         }
     });