Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add/implement pc.EVENT_MOUSEOUT and pc.EVENT_MOUSEENTER #4920
base: main
Are you sure you want to change the base?
Add/implement pc.EVENT_MOUSEOUT and pc.EVENT_MOUSEENTER #4920
Changes from 8 commits
7c582ab
d8adc32
10d3655
a2c8c28
3faf2ba
6386212
3ba5cc3
2395405
6875316
f7dbb3b
d7233cb
5912854
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slightly confused here since the description is identical to the first sentence of the description for
EVENT_MOUSEOUT
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the same note, what values are coords.x/y on a mouse out event?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
coords = mouse._getTargetCoords(event);
returns null and then the constructor just ends here:engine/src/platform/input/mouse-event.js
Lines 56 to 58 in 7c582ab
Resulting in the entire event being "uninitialized".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yaustar There are two cases:
mouseout
is fired and then its the normalx
/y
_getTargetCoords
returns null andx
/y
sticks to 0 (because_getTargetCoords
returns some proper values).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see 🤔 This seems fine to me