Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESM First Person Controller #7252

Merged
merged 10 commits into from
Jan 13, 2025
Merged

ESM First Person Controller #7252

merged 10 commits into from
Jan 13, 2025

Conversation

kpal81xd
Copy link
Contributor

@kpal81xd kpal81xd commented Jan 8, 2025 •
edited
Loading

  • Rewrote all first person scripts into ESM
  • Renamed CharacterController to FirstPersonController
  • Folded all input classes inside FirstPersonController

@kpal81xd kpal81xd self-assigned this Jan 8, 2025
@kpal81xd kpal81xd changed the title ESM First Person Controls ESM Character Controls Jan 8, 2025
@kpal81xd kpal81xd requested a review from willeastcott January 8, 2025 15:28
@kpal81xd kpal81xd requested a review from a team January 13, 2025 14:45
@kpal81xd kpal81xd changed the title ESM Character Controls ESM First Person Controller Jan 13, 2025
willeastcott
willeastcott approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@willeastcott willeastcott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kpal81xd kpal81xd merged commit 9012f37 into main Jan 13, 2025
7 checks passed
@kpal81xd kpal81xd deleted the fps branch January 13, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

Assignees

@kpal81xd kpal81xd

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kpal81xd @willeastcott