Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data panel #127

Merged
merged 27 commits into from
Jul 10, 2024
Merged

Add data panel #127

merged 27 commits into from
Jul 10, 2024

Conversation

slimbuck
Copy link
Member

@slimbuck slimbuck commented Jul 10, 2024

Screenshot 2024-07-10 at 13 51 06

This PR:

  • adds a new collapsable data panel below the 3d view
    • the view displays histogram for currently selected splat data
    • user can choose to plot one of the following properties:
      • X, Y, Z, Volume, Surface Area, Scale X, Scale Y, Scale Z, Red, Green, Blue, Opacity, Hue, Saturation, Value
    • click and drag on histogram to modify selection (using shift to add and ctrl to remove from selection)
    • hover mouse over histogram to see bucket values and counts.
  • removed 'Select by opacity' and 'Select by Size' from control panel since histogram select is much more powerful
  • bumped package version

@slimbuck slimbuck added the enhancement New feature label Jul 10, 2024
@slimbuck slimbuck requested a review from a team July 10, 2024 13:04
@slimbuck slimbuck self-assigned this Jul 10, 2024
src/ui/data-panel.ts Outdated Show resolved Hide resolved
src/ui/data-panel.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@willeastcott willeastcott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't wait to see what people think of this update!

@slimbuck slimbuck merged commit 18fbe5a into main Jul 10, 2024
2 checks passed
@slimbuck slimbuck deleted the histogram branch July 10, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants