Compress-selection#207
Closed
simonbethke wants to merge 5 commits intoplaycanvas:mainfrom
Closed
Conversation
Closed
Contributor
Author
|
@slimbuck is this something you have already solved in a different way or is there something fundamental which you don't like on this implementation, but I should give it another shot from a different starting point? |
Member
|
This idea was eventually rolled into #803. Closing, but with a little sadness to see it go :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an improvement to shrink the memory footprint of the undo-history.
What this basically does is, that a indices are combined as ranges if they cover more than one subsequent. So this:
1, 2, 3, 4, 5, 6, 10
becomes:
1-6, 10
When selecting only few splats, this compression shows results in a typical range of 50 - 100% of the uncompressed size.
When selecting many splats like a tenth of the scene, it becomes more efficient and the typical compressed size is 2-20%.
When selecting almost all splats, the compressed size is less than 1%.