Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update splat sorting #323

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Update splat sorting #323

merged 1 commit into from
Dec 10, 2024

Conversation

slimbuck
Copy link
Member

@slimbuck slimbuck commented Dec 10, 2024 •
edited
Loading

This PR:

  • updates the sort order of splats to based on their furtherst bounding box extent, instead of the bounding box center
  • this results in much better render order for large and overlapping splats

Before:
Screenshot 2024-12-10 at 15 30 38

After:
Screenshot 2024-12-10 at 15 28 56

@slimbuck slimbuck added the enhancement New feature label Dec 10, 2024
@slimbuck slimbuck requested a review from a team December 10, 2024 15:28
@slimbuck slimbuck self-assigned this Dec 10, 2024
@mvaligursky
Copy link

It'd be good to add this to the engine as well?

@slimbuck slimbuck merged commit 5b8f6a9 into playcanvas:main Dec 10, 2024
2 checks passed
@slimbuck slimbuck deleted the sort-dev branch December 10, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvaligursky mvaligursky mvaligursky approved these changes

Assignees

@slimbuck slimbuck

Labels
enhancement New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slimbuck @mvaligursky