Make package UPM compatible for GPGS 2.0

[Thaina]

• Move Sample to Package/Sample~
• Using raw java file to build instead of rely on gradle build
• Patching androidmanifest with AssetImporter
• Move MenuItem out to "Google/"
• Use PlayerProfile directly

[Davidnovarro]

We need this :)

[miladEsk]

Hello, If I use this branch instead of master could fix this issue I have:
Getting this ERROR: Returning an error code #3348

[RaphaelNSG]

Hello @Thaina ,

With new version of Unity the GPGSUtil.cs it's not finding the the plugin folder when using UPM. Can you already fix this on this Pull Request?
Issue: 250742

[Thaina]

@RaphaelNSG I use my package in many version include 6000 and never see that problem

[RaphaelNSG]

@Thaina With me and with the people on this (#3163) issue is happening. Did you tried with Unity 2022?
My Unity is 2022.3.58f1 and my OS is MacOS 14

[Thaina]

Not sure about osx, have you tried with 6000 yet?

[RaphaelNSG]

Actually o notice that in you branch the GPGSUilt.cs its already updated to search in the cache package:

#if UNITY_2018_4_OR_NEWER
                        // search for remote UPM installation
                        Path.Join("Library","PackageCache"),
                        "Packages",
#endif

I tried with the master branch. Sorry

[ErnSur]

You could update the changelog to mention all changes like changing the menu item paths. It would also make the review easier

[mizunokazumi]

@Thaina javaScopesList is missing
Raises error
System.Exception: No such proxy method: GooglePlayGames.Android.AndroidTaskUtils+TaskOnSuccessProxy1[UnityEngine.AndroidJavaObject].onSuccess(System.String)`

[Thaina]

Could you try fork this and change task.AddOnSuccessListener<AndroidJavaObject> to task.AddOnSuccessListener<string> instead?

[mizunokazumi]

Most likely it helps, but why?
Above there is a separate RequestServerSideAccess method without scopes support. And this method is specifically for a request with scopes specified. Returning javaScopesList to the list as an argument fixes the problem

- using (var task = client.Call<AndroidJavaObject>("requestServerSideAccess", WebClientId, forceRefreshToken))
+ using (var task = client.Call<AndroidJavaObject>("requestServerSideAccess", WebClientId, forceRefreshToken, javaScopesList))

[Thaina]

@mizunokazumi Sorry I misread the problem

Request serverside access was just added recently. I don't have time to update yet

https://github.com/playgameservices/play-games-plugin-for-unity/releases/tag/v2.1.0