[VP][DAGCombiner] Use simplifySelect when combining vp.select.
#66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c (#79101)
support vp.select
TODO: Possibly other functions could be supported, eg: SimplifySelect()
|
内部仓库可以合并，但是我还是觉得这种方式upstream是不接受的，但也可以去试试 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #79101. Adding
simplifySelecttovisitVP_SELECTdoes not result in too much modifications.simplifySelectdoes not fold vselect(1, T, F) to T. Although we can check if acondis all ones to achieve this, as a92f5a0 suggests it might be more complex, so I think it is reasonable to place related modifications in a separate PR.