Skip to content
This repository has been archived by the owner on Jul 2, 2022. It is now read-only.

cider-cljs-lein-repl is deprecated. #233

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cider-cljs-lein-repl is deprecated. #233

wants to merge 1 commit into from

Conversation

ponkore
Copy link
Contributor

@ponkore ponkore commented Apr 14, 2018

In the latest version of CIDER, cider-cljs-lein-repl is deprecated.
Emacs says:

 cider-cljs-lein-repl is obsolete (since 0.17); use ‘cider-default-cljs-repl’ instead

This PR fix it.

@featheredtoast
Copy link
Collaborator

Hey thanks for the PR! I will merge this once cider's 0.17 is out.

@plexus
Copy link
Owner

plexus commented Apr 17, 2018

How about setting both for the time being? That way both pre-1.7 and post-1.7 users are covered. Maybe add a comment

;; CIDER up to version 0.16
cider-cljs-lein-repl ,,,
;; CIDER versions 0.17 and after
cider-default-cljs-repl ,,,

@@ -1,3 +1,3 @@
((nil . ((cider-refresh-before-fn . "reloaded.repl/suspend")
(cider-refresh-after-fn . "reloaded.repl/resume")
(cider-cljs-lein-repl . "(do (user/go) (user/cljs-repl))"))))
(cider-default-cljs-repl . "(do (user/go) (user/cljs-repl))"))))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cider-default-cljs-repl should reference a REPL type, so this should be more like:
(eval . (cider-register-cljs-repl-type 'chestnut "(do (user/go) (user/cljs-repl))"))
(cider-default-cljs-repl . chestnut)

@ghost
Copy link

ghost commented Apr 29, 2021

What is the status of this? I'm trying out Chestnut for the first time, and I'm getting this error. The pull request looks like it's from 2018. Is this project still being maintained?

@plexus
Copy link
Owner

plexus commented Apr 30, 2021

Chestnut does not represent current best practices. A lot has happened since Chestnut was created, and you can get away with a much simpler setup now.

My recommendations

  • use deps.clj/clojure CLI instead of project.clj/leiningen
  • use figwheel-main or shadow-cljs, not figwheel classic
  • use jetty if you want a backend server, with compojure (as used in Chestnut) or reitit (the more modern option)
  • use integrant instead of Stuart Sierra's Component

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants