Skip to content

Commit

Permalink
[fc] Repository: mockup
Browse files Browse the repository at this point in the history
Branch: refs/heads/master
Date: 2022-05-17T22:46:58+02:00
Author: Johannes Raggam (thet) <[email protected]>
Commit: plone/mockup@abd58f7

maint(Cleanup): Remove pat-content-browser.

This can be provided by an external bundle.

Files changed:
M package.json
M webpack.config.js
Repository: mockup

Branch: refs/heads/master
Date: 2022-05-17T22:47:03+02:00
Author: Johannes Raggam (thet) <[email protected]>
Commit: plone/mockup@f749505

maint(Cleanup): Cleanup unused parameter in webpack config.

Files changed:
M webpack.config.js
Repository: mockup

Branch: refs/heads/master
Date: 2022-05-17T22:47:03+02:00
Author: Johannes Raggam (thet) <[email protected]>
Commit: plone/mockup@13d0e0d

maint(pat querystring): Cleanup - direct import of Select2 is not necessary.

Files changed:
M src/pat/querystring/querystring.js
Repository: mockup

Branch: refs/heads/master
Date: 2022-05-17T22:47:03+02:00
Author: Johannes Raggam (thet) <[email protected]>
Commit: plone/mockup@0a7c631

fix(relateditems): Move Select2 out of init.

If it wasn't already registered, it would register and scan the document now.
If there were previous relateditems already modifying the DOM structure
and placing pat-select2 classes to some items, the import here would try
to initialize them.
But those pat-select2 items were meant to be initialized via the
Patternslib API and not automatically and are missing some configuration
needed by select2 (query attribute...).
By moving the Select2 out of the init and importing it early fixes this
problem.

Note: This happened in plone.app.mosaic with module federation.
pat-select2 was already directly imported by the main Mockup bundle.
But since we didn't have a global pattern registry, the pattern was
re-initialized where it wouldn't have to.
Since the change in Patternslib 8.0.0 with a global pattern registry
this fix might become obsolete.

However, we should have an eye on dynamic pattern imports immediately
registering and scanning the docment and possibly prevent that in some
way.

See: Patternslib/Patterns#961

Files changed:
M src/pat/relateditems/relateditems.js
Repository: mockup

Branch: refs/heads/master
Date: 2022-05-17T22:51:14+02:00
Author: Johannes Raggam (thet) <[email protected]>
Commit: plone/mockup@6aefc4b

feat(Build): Use dynamic module federation.

Files changed:
M package.json
M src/index.js
M src/patterns.js
M webpack.config.js
Repository: mockup

Branch: refs/heads/master
Date: 2022-05-17T22:51:14+02:00
Author: Johannes Raggam (thet) <[email protected]>
Commit: plone/mockup@62332d1

maint(Makefile): Add watch-plone and bundle-plone targets to Makefile.

Files changed:
M Makefile
Repository: mockup

Branch: refs/heads/master
Date: 2022-05-17T22:51:14+02:00
Author: Johannes Raggam (thet) <[email protected]>
Commit: plone/mockup@acf9839

maint(Build): Add build:webpack:dev:plone as package.json script to allow for a Plone development build.

Files changed:
M package.json
Repository: mockup

Branch: refs/heads/master
Date: 2022-05-17T22:53:29+02:00
Author: Johannes Raggam (thet) <[email protected]>
Commit: plone/mockup@b354af4

yarn install.

Files changed:
M yarn.lock
Repository: mockup

Branch: refs/heads/master
Date: 2022-05-17T22:59:38+02:00
Author: Johannes Raggam (thet) <[email protected]>
Commit: plone/mockup@e795ff4

Merge pull request #1112 from plone/es6-module-federation

es6 module federation

Files changed:
M Makefile
M package.json
M src/index.js
M src/pat/querystring/querystring.js
M src/pat/relateditems/relateditems.js
M src/patterns.js
M webpack.config.js
M yarn.lock
  • Loading branch information
thet committed May 17, 2022
1 parent 2fb8a03 commit adb14d4
Showing 1 changed file with 150 additions and 7 deletions.
157 changes: 150 additions & 7 deletions last_commit.txt

Large diffs are not rendered by default.

0 comments on commit adb14d4

Please sign in to comment.