Currently make linkcheckbroken allows PRs with broken links to be merged. This is not OK. It makes Plone documentation look amateurish, like someone's hobby project. Yes, we're volunteers, but come on, let's take some pride. There's no good reason to introduce broken links and references, especially when we have automated tools to help us.
Of course, when external entities change their URLs or block linkcheck, we need to fix them separately.
This also needs to be enforced in the submodules, so we can catch broken links before they get merged in those repositories:
Currently
make linkcheckbrokenallows PRs with broken links to be merged. This is not OK. It makes Plone documentation look amateurish, like someone's hobby project. Yes, we're volunteers, but come on, let's take some pride. There's no good reason to introduce broken links and references, especially when we have automated tools to help us.Of course, when external entities change their URLs or block linkcheck, we need to fix them separately.
This also needs to be enforced in the submodules, so we can catch broken links before they get merged in those repositories: