Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate a sitemap-index and split the contents in several sitemap.xml.gz files #382

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

erral
Copy link
Member

@erral erral commented Jan 28, 2025

Fixes #381
Merge together: plone/plone.app.multilingual#481

I went for the following solution:

  • In the sitemap.xml.gz file we render the "sitemp index" file, that renders links to several sitemap.xml.gz?page=XX files
  • When querying sitemap.xml.gz?page=XX it runs the relevant query in the catalog, and uses the XXth batch to render the sitemap links.

@mister-roboto
Copy link

@erral thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@erral
Copy link
Member Author

erral commented Jan 28, 2025

@jenkins-plone-org please run jobs

@erral
Copy link
Member Author

erral commented Jan 28, 2025

@jenkins-plone-org please run jobs

1 similar comment
@erral
Copy link
Member Author

erral commented Jan 28, 2025

@jenkins-plone-org please run jobs

@erral
Copy link
Member Author

erral commented Feb 3, 2025

Before merging this, I will test it in a site of ours to check that Google reports no errors.

@erral
Copy link
Member Author

erral commented Feb 11, 2025

We have this branch in production for 2 weeks and Search Console reports that the index file is correct.

@erral
Copy link
Member Author

erral commented Feb 11, 2025

@jenkins-plone-org please run jobs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sitemap.xml.gz has limit of 50.000 items
4 participants