Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #47

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

@mister-roboto
Copy link

@pre-commit-ci[bot] thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

updates:
- [github.com/asottile/pyupgrade: v3.15.2 → v3.16.0](asottile/pyupgrade@v3.15.2...v3.16.0)
- [github.com/PyCQA/flake8: 7.0.0 → 7.1.0](PyCQA/flake8@7.0.0...7.1.0)
- [github.com/codespell-project/codespell: v2.2.6 → v2.3.0](codespell-project/codespell@v2.2.6...v2.3.0)
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 3d46818 to 3e8211e Compare July 1, 2024 20:47
@gforcada gforcada force-pushed the pre-commit-ci-update-config branch 2 times, most recently from 0ad0de2 to 490d746 Compare July 2, 2024 04:49
@gforcada gforcada force-pushed the pre-commit-ci-update-config branch from 1ffc910 to ef61dd6 Compare July 2, 2024 04:55
@gforcada
Copy link
Member

gforcada commented Jul 2, 2024

@davisagli would it be ok to drop pypy3 temporarily? seems that plone/meta needs some fixes/improvements to handle it, but meanwhile, at least GHA would pass.

I'm not sure why test.yml break with plone/meta changes 🤔 I can try to have a look, but as of late seems I don't have much time, so that might not be much of a promise 🫣

@mauritsvanrees
Copy link
Member

@davisagli would it be ok to drop pypy3 temporarily? seems that plone/meta needs some fixes/improvements to handle it, but meanwhile, at least GHA would pass.

I think this is fine. From a Plone standpoint, PyPy3 does not need to be supported, as Plone uses C-code (in some Zope packages). But if someone needs it outside of Plone and steps up, we can try to support it again. Maybe a separate GitHub actions file that is not touched at all by plone/meta.

@mauritsvanrees mauritsvanrees merged commit 0c89d75 into master Jul 30, 2024
13 of 17 checks passed
@mauritsvanrees mauritsvanrees deleted the pre-commit-ci-update-config branch July 30, 2024 14:18
@mauritsvanrees
Copy link
Member

I have added a news snippet to say that we currently do not test on PyPy3.

@davisagli
Copy link
Member

@mauritsvanrees You also ought to update the trove classifiers in setup.py

@mauritsvanrees
Copy link
Member

@davisagli I think it is fine to leave PyPy in the classifiers: we do not drop support, we only no longer test it.

@davisagli
Copy link
Member

@mauritsvanrees If we do not test it, then we cannot make any claim that it is supported, in my opinion.

@mauritsvanrees
Copy link
Member

@davisagli I have a better idea: restore PyPy3 support in the test setup. :-D. See PR #49.

Apparently the correct way of asking for PyPy3 in actions/setup-python is pypy3.9
The only downside is a slightly weird looking test job "pypypy3.9".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants