-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pre-commit.ci] pre-commit autoupdate #47
Conversation
@pre-commit-ci[bot] thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
updates: - [github.com/asottile/pyupgrade: v3.15.2 → v3.16.0](asottile/pyupgrade@v3.15.2...v3.16.0) - [github.com/PyCQA/flake8: 7.0.0 → 7.1.0](PyCQA/flake8@7.0.0...7.1.0) - [github.com/codespell-project/codespell: v2.2.6 → v2.3.0](codespell-project/codespell@v2.2.6...v2.3.0)
3d46818
to
3e8211e
Compare
0ad0de2
to
490d746
Compare
1ffc910
to
ef61dd6
Compare
@davisagli would it be ok to drop I'm not sure why |
I think this is fine. From a Plone standpoint, PyPy3 does not need to be supported, as Plone uses C-code (in some Zope packages). But if someone needs it outside of Plone and steps up, we can try to support it again. Maybe a separate GitHub actions file that is not touched at all by plone/meta. |
I have added a news snippet to say that we currently do not test on PyPy3. |
@mauritsvanrees You also ought to update the trove classifiers in setup.py |
@davisagli I think it is fine to leave PyPy in the classifiers: we do not drop support, we only no longer test it. |
@mauritsvanrees If we do not test it, then we cannot make any claim that it is supported, in my opinion. |
@davisagli I have a better idea: restore PyPy3 support in the test setup. :-D. See PR #49. Apparently the correct way of asking for PyPy3 in |
updates: