Configuring with plone.meta #1945
Conversation
|
@gforcada thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
* Some json files get an extra "context" url.
* "lock" is no longer an empty dict, but `{"locked": false, "stealable": true}`
* `plone.app.layout` has a GS profile now. See also plone/plone.classicui#23
There was a problem hiding this comment.
LGTM.
But the check for uncommitted doc changes fails. This check would already fail on the main branch because I have updated the 6.2-dev directory on dist.plone.org last week, which includes alpha releases for plone.app.layout and plone.locking and these cause the doc changes.
So I ran the 6.2 tests locally and have committed the doc changes. See the last commit. @davisagli Can you check whether those changes make sense?
For the extra plone.app.layout:default profile that gets reported: see plone/plone.classicui#23 that I just opened.
|
@mauritsvanrees Yeah, that looks fine to me. thanks for updating it |
|
@jenkins-plone-org please run jobs |
No description provided.