fix

ploomber · Jan 12, 2024 · dc1d126 · dc1d126
1 parent 0cdce8f
commit dc1d126
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 12 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,8 @@
 
 ## 0.2.21dev
 
+* [Fix] Fix error when determining if telemetry call was from a cloud user
+
 ## 0.2.20 (2024-01-12)
 
 * [Feature] Obtain system info once for faster initialization

diff --git a/src/ploomber_core/telemetry/telemetry.py b/src/ploomber_core/telemetry/telemetry.py
@@ -242,7 +242,7 @@ def is_cloud_user():
     returns True/False accordingly.
     """
     settings = UserSettings()
-    return settings.cloud_key
+    return settings.cloud_key is not None
 
 
 def email_registered():

diff --git a/tests/telemetry/test_telemetry_log_args.py b/tests/telemetry/test_telemetry_log_args.py
@@ -55,7 +55,7 @@ def add(x, y):
             "version": "0.1",
             "package_name": "somepackage",
             "docker_container": False,
-            "cloud": None,
+            "cloud": ANY,
             "email": None,
             "os": ANY,
             "environment": ANY,
@@ -108,7 +108,7 @@ def add(self, x, y):
             "version": "0.1",
             "package_name": "somepackage",
             "docker_container": False,
-            "cloud": None,
+            "cloud": ANY,
             "email": None,
             "os": ANY,
             "environment": ANY,
@@ -147,7 +147,7 @@ def add(x, y=1):
             "version": "0.1",
             "package_name": "somepackage",
             "docker_container": False,
-            "cloud": None,
+            "cloud": ANY,
             "email": None,
             "os": ANY,
             "environment": ANY,
@@ -186,7 +186,7 @@ def add(x, y=1):
             "version": "0.1",
             "package_name": "somepackage",
             "docker_container": False,
-            "cloud": None,
+            "cloud": ANY,
             "email": None,
             "os": ANY,
             "environment": ANY,
@@ -228,7 +228,7 @@ def add(x, y=1):
             "version": "0.1",
             "package_name": "somepackage",
             "docker_container": False,
-            "cloud": None,
+            "cloud": ANY,
             "email": None,
             "os": ANY,
             "environment": ANY,
@@ -288,7 +288,7 @@ def substract(self, x, y):
             "version": "0.1",
             "package_name": "somepackage",
             "docker_container": False,
-            "cloud": None,
+            "cloud": ANY,
             "email": None,
             "os": ANY,
             "environment": ANY,
@@ -313,7 +313,7 @@ def substract(self, x, y):
             "version": "0.1",
             "package_name": "somepackage",
             "docker_container": False,
-            "cloud": None,
+            "cloud": ANY,
             "email": None,
             "os": ANY,
             "environment": ANY,
@@ -355,7 +355,7 @@ def do_stuff(self):
             "version": "0.1",
             "package_name": "somepackage",
             "docker_container": False,
-            "cloud": None,
+            "cloud": ANY,
             "email": None,
             "os": ANY,
             "environment": ANY,
@@ -394,7 +394,7 @@ def do_stuff():
             "version": "0.1",
             "package_name": "somepackage",
             "docker_container": False,
-            "cloud": None,
+            "cloud": ANY,
             "email": None,
             "os": ANY,
             "environment": ANY,
@@ -433,7 +433,7 @@ def do_stuff(a, *args):
             "version": "0.1",
             "package_name": "somepackage",
             "docker_container": False,
-            "cloud": None,
+            "cloud": ANY,
             "email": None,
             "os": ANY,
             "environment": ANY,
@@ -472,7 +472,7 @@ def do_stuff(a, **kwargs):
             "version": "0.1",
             "package_name": "somepackage",
             "docker_container": False,
-            "cloud": None,
+            "cloud": ANY,
             "email": None,
             "os": ANY,
             "environment": ANY,