Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Book recommender #127

Merged
merged 18 commits into from
Mar 1, 2024
Merged

Book recommender #127

merged 18 commits into from
Mar 1, 2024

Conversation

neelasha23
Copy link
Contributor

@neelasha23 neelasha23 commented Feb 28, 2024

Closes #95


📚 Documentation preview 📚: https://ploomber-doc--127.org.readthedocs.build/en/127/

@neelasha23
Copy link
Contributor Author

@neelasha23 neelasha23 marked this pull request as ready for review February 28, 2024 19:55
Copy link
Contributor

@edublancas edublancas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have many questions about the logic

also, please ensure your docstrings are accurate and you either use logging or remove print statements before requesting a review

examples/panel/book-recommender/app.py Outdated Show resolved Hide resolved
examples/panel/book-recommender/app.py Outdated Show resolved Hide resolved
examples/panel/book-recommender/app.py Outdated Show resolved Hide resolved
examples/panel/book-recommender/assets/author_to_title.pkl Outdated Show resolved Hide resolved
examples/panel/book-recommender/rag_book_recommender.py Outdated Show resolved Hide resolved
examples/panel/book-recommender/rag_book_recommender.py Outdated Show resolved Hide resolved
examples/panel/book-recommender/app.py Outdated Show resolved Hide resolved
examples/panel/book-recommender/app.py Show resolved Hide resolved
examples/panel/book-recommender/rag_book_recommender.py Outdated Show resolved Hide resolved
@neelasha23
Copy link
Contributor Author

neelasha23 commented Feb 29, 2024

App with 50 embeddings: https://blue-mouse-7632.ploomberapp.io/app
App with embeddings of all books: https://long-poetry-2770.ploomberapp.io/app
Addressed the review comments
@edublancas

Copy link
Contributor

@edublancas edublancas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments, looking good!

examples/panel/book-recommender/assets/embeddings.json Outdated Show resolved Hide resolved
examples/panel/book-recommender/assets/goodreads.csv Outdated Show resolved Hide resolved
@neelasha23 neelasha23 requested a review from bryannho as a code owner March 1, 2024 04:10
@neelasha23
Copy link
Contributor Author

Addressed comment. Please review @edublancas

@neelasha23 neelasha23 requested a review from edublancas March 1, 2024 04:55
@edublancas edublancas merged commit 5afc945 into main Mar 1, 2024
1 check passed
@edublancas edublancas deleted the book branch March 1, 2024 14:22
@edublancas
Copy link
Contributor

@neelasha23 please delete the application with 50 embeddings

ensure the other app is running the latest version and prepare the social media posts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

demo: book recommender
2 participants