Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

custom subdomain instructions added #168

Merged
merged 2 commits into from
Apr 4, 2024
Merged

custom subdomain instructions added #168

merged 2 commits into from
Apr 4, 2024

Conversation

yafimvo
Copy link
Contributor

@yafimvo yafimvo commented Mar 27, 2024 •
edited by github-actions bot
Loading

@yafimvo yafimvo requested a review from idomic March 27, 2024 09:51
@edublancas edublancas requested a review from bryannho March 28, 2024 05:36
@edublancas
Copy link
Contributor

@bryannho @neelasha23 please review. you won't be able to test this since this involves changing DNS records. so focus on readability

let's merge this until this is in prod

@edublancas edublancas added the stash Label used to categorize issues that will be worked on next label Mar 28, 2024
@edublancas edublancas merged commit bb3650a into main Apr 4, 2024
1 check passed
@edublancas edublancas deleted the custom_subdomains branch April 4, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryannho bryannho bryannho approved these changes

@neelasha23 neelasha23 neelasha23 approved these changes

@edublancas edublancas edublancas approved these changes

@idomic idomic Awaiting requested review from idomic

Assignees
No one assigned
Labels
stash Label used to categorize issues that will be worked on next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yafimvo @edublancas @neelasha23 @bryannho