Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Environment Variables section in docs #171

Merged
merged 6 commits into from
Mar 29, 2024
Merged

Update Environment Variables section in docs #171

merged 6 commits into from
Mar 29, 2024

Conversation

bryannho
Copy link
Contributor

@bryannho bryannho commented Mar 29, 2024 •
edited by github-actions bot
Loading

Changes

  • Rename env-vars.md to secrets.md and replace all occurences of environment variables to secrets
  • Update Environment variables section in cli.md
  • Replace static images

Addresses #169

📚 Documentation preview 📚: https://ploomber-doc--171.org.readthedocs.build/en/171/

@bryannho bryannho marked this pull request as ready for review March 29, 2024 07:39
edublancas
edublancas requested changes Mar 29, 2024
View reviewed changes
doc/user-guide/cli.md Show resolved Hide resolved
doc/user-guide/secrets.md Outdated Show resolved Hide resolved
@edublancas edublancas merged commit 5a5e410 into main Mar 29, 2024
1 check passed
@edublancas edublancas deleted the secrets-doc-fix branch March 29, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neelasha23 neelasha23 neelasha23 approved these changes

@edublancas edublancas Awaiting requested review from edublancas edublancas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bryannho @edublancas @neelasha23