Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move streamlit zip file content out of directory #174

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

94rain
Copy link
Contributor

@94rain 94rain commented Apr 3, 2024

The zip file for the Streamlit data visualization example places its project files within an app directory, which is inconsistent with the directory structure used in other projects. Moving them out to the root of the zip file for a uniformed directory layout across all example projects (to be used for integration tests with CLI)


📚 Documentation preview 📚: https://ploomber-doc--174.org.readthedocs.build/en/174/

@bryannho
Copy link
Contributor

bryannho commented Apr 3, 2024

@94rain I might be missing something here, but can you re-explain what was wrong with the zip file initially? I tried unzipping the file without pulling your changes and it looks like it behaves consistently with the other zip files:

Screen.Recording.2024-04-03.at.4.23.59.PM.mov

I then tried pulling your changes and it looks the same.

@94rain
Copy link
Contributor Author

94rain commented Apr 4, 2024

This is what I got when running zipinfo: examples/streamlit/data-viz/app.zip does have a directory app/ inside.

$ zipinfo examples/streamlit/data-viz/app.zip
Archive:  examples/streamlit/data-viz/app.zip
Zip file size: 1137 bytes, number of entries: 3
drwxr-xr-x  2.0 unx        0 bx stor 23-Nov-01 16:42 app/
-rw-r--r--  2.0 unx       22 bX defN 23-Oct-30 17:02 app/requirements.txt
-rw-r--r--  2.0 unx     1073 bX defN 23-Oct-30 17:02 app/app.py
3 files, 1095 bytes uncompressed, 595 bytes compressed:  45.7%
$ zipinfo examples/streamlit/basic-app/app.zip
Archive:  examples/streamlit/basic-app/app.zip
Zip file size: 1205 bytes, number of entries: 4
-rw-r--r--  2.0 unx       62 bX defN 23-Oct-01 23:23 app.py
-rw-r--r--  2.0 unx      176 bX defN 23-Oct-01 23:23 __MACOSX/._app.py
-rw-r--r--  2.0 unx      416 bX defN 23-Oct-04 17:51 Dockerfile
-rw-r--r--  2.0 unx      176 bX defN 23-Oct-04 17:51 __MACOSX/._Dockerfile
4 files, 830 bytes uncompressed, 451 bytes compressed:  45.7%

Copy link
Contributor

@bryannho bryannho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I see. Weird how it doesn't unzip into the subdirectory, but I get the same result from zipinfo.

@edublancas edublancas merged commit 7239570 into main Apr 4, 2024
2 checks passed
@edublancas edublancas deleted the update-streamlit-zip branch April 4, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants