Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing options in CLI guide #195

Merged
merged 6 commits into from
Apr 18, 2024
Merged

Added missing options in CLI guide #195

merged 6 commits into from
Apr 18, 2024

Conversation

neelasha23
Copy link
Contributor

@neelasha23 neelasha23 commented Apr 17, 2024

Closes #185 #193


📚 Documentation preview 📚: https://ploomber-doc--195.org.readthedocs.build/en/195/

fix ref

fix ref

fix ref

fix ref

links

links
@neelasha23 neelasha23 marked this pull request as ready for review April 17, 2024 17:35
@neelasha23 neelasha23 requested a review from edublancas as a code owner April 17, 2024 17:35
@@ -18,6 +18,7 @@ sphinx:
navigation_with_keys: true
html_static_path:
- static/opengraph
myst_heading_anchors: 2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this doing? why do we need it? please add a comment so we know why we added it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Without this configuration referencing header sections in other other files doesn't work

@neelasha23 neelasha23 requested a review from edublancas April 18, 2024 05:11
@edublancas edublancas merged commit 25c4800 into main Apr 18, 2024
1 check passed
@edublancas edublancas deleted the issue185 branch April 18, 2024 05:49
@edublancas
Copy link
Contributor

@neelasha23 when your PR closes >1 issue, list them in separate lines

closes #x
closes #y

otherwise github won't close them automatically

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

check that all cli options are documented
2 participants