Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch incremental #211

Merged
merged 5 commits into from
May 2, 2024
Merged

Watch incremental #211

merged 5 commits into from
May 2, 2024

Conversation

neelasha23
Copy link
Contributor

@neelasha23 neelasha23 commented Apr 30, 2024

@neelasha23 neelasha23 marked this pull request as ready for review April 30, 2024 13:29
@neelasha23 neelasha23 requested a review from edublancas as a code owner April 30, 2024 13:29
@@ -47,6 +47,12 @@ add the `--watch` flag.
ploomber-cloud deploy --watch
```

You can also use the `--watch-incremental` flag to view only the newly added logs with every polling.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this description is confusing it says "only the newly added logs", does that mean that --watch will print all the logs on every update? (I don't think that's the case)

it's unclear wh I'd use one option over the other one

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the gist of it is:

use --watch if deploying from your terminal as it'll clear your screen
use --watch-incremental if storing the deployment output into a file (e.g. github actions) as it won't attempt to clear the screen and only print new logs and status updates

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for missing the previous comment.

fixed

@neelasha23 neelasha23 requested a review from edublancas May 2, 2024 19:34
@edublancas edublancas merged commit c03a67b into main May 2, 2024
1 check passed
@edublancas edublancas deleted the watch branch May 2, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants