Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Flask docs and examples #223

Merged
merged 7 commits into from
May 14, 2024
Merged

Conversation

bryannho
Copy link
Contributor

@bryannho bryannho commented May 13, 2024

  • Update flask.md
  • Update docker.md to use FastAPI since Flask is now natively supported
  • Update all Flask examples to remove Dockerfiles

Closes #221

@bryannho bryannho marked this pull request as ready for review May 13, 2024 23:35
Copy link
Contributor

@neelasha23 neelasha23 May 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Scheduled Functions can be removed. Refer to this comment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in this commit.

Not sure why the change isn't updating in the readthedocs build but it renders correctly locally and you should see the file has been changed

@bryannho bryannho requested a review from neelasha23 May 14, 2024 18:13
@edublancas edublancas merged commit 431134d into main May 14, 2024
1 check passed
@edublancas edublancas deleted the bryan/update-flask-examples branch May 14, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update flask docs
3 participants