Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo app for Dash to connect to PostgreSQL #259

Merged
merged 14 commits into from
Jul 29, 2024
Merged

Conversation

bchen39
Copy link
Contributor

@bchen39 bchen39 commented Jul 25, 2024

Added example Dash app that is connected to Postgres database.

Closes ploomber.io#186


📚 Documentation preview 📚: https://ploomber-doc--259.org.readthedocs.build/en/259/

@bryannho
Copy link
Contributor

bryannho commented Jul 25, 2024

@bchen39 Please deploy the app send the link to make it easier for us to test. Let me know if you still need your dev account upgraded

@bchen39
Copy link
Contributor Author

bchen39 commented Jul 25, 2024

@bchen39 Please deploy the app send the link to make it easier for us to test. Let me know if you still need your dev account upgraded

link to app, let me know if this works

Copy link
Contributor

@bryannho bryannho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bchen39 It looks like it's down, but it was working before. If you didn't delete it, it might have gotten cleaned up automatically.

image

A few notes from brief testing:

  • Add a paragraph under the title to provide some context for each of the datasets. It's hard to understand what each one describes
  • Some of the columns don't make sense without context (Walc, etc.). Might be clearer to re-phrase these or just delete them
  • Changing the axes via the dropdown didn't reload the graphs (couldn't verify since the app went down)

Only keep readable data and added more detailed description.
@bchen39
Copy link
Contributor Author

bchen39 commented Jul 26, 2024

@bchen39 It looks like it's down, but it was working before. If you didn't delete it, it might have gotten cleaned up automatically.

image

A few notes from brief testing:

  • Add a paragraph under the title to provide some context for each of the datasets. It's hard to understand what each one describes
  • Some of the columns don't make sense without context (Walc, etc.). Might be clearer to re-phrase these or just delete them
  • Changing the axes via the dropdown didn't reload the graphs (couldn't verify since the app went down)

@bryannho Please check my latest version. I made sure the title of each graph explains what they are, and cleaned up data that do not make sense. The app should work properly now. Let me know in case the app gets cleaned up again and I can redeploy.

@bchen39 bchen39 requested a review from bryannho July 26, 2024 15:29
@edublancas
Copy link
Contributor

edublancas commented Jul 26, 2024

@bchen39 let's use the prod environment from now on for the demo apps

@ploomber ploomber deleted a comment from bchen39 Jul 26, 2024
@bryannho
Copy link
Contributor

@bchen39 it got cleaned up, please deploy on prod and resend the link. @edublancas I think he'll need a pro account since it's a docker app, can he use the [email protected] one?

@edublancas
Copy link
Contributor

@bchen39 DM me your prod account via Slack so I upgrade it.

@bryannho I think let's use separate accounts so we have better control, I'll manually keep an eye on the apps to shut down the ones we're not using

@bchen39
Copy link
Contributor Author

bchen39 commented Jul 26, 2024

@bryannho link to app on prod environment. This should work now.

bryannho
bryannho previously approved these changes Jul 26, 2024
Copy link
Contributor

@bryannho bryannho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Contributor

@edublancas edublancas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments regarding secrets. ensure to mention this in the blog post: that people should use our secrets feature

also, since the db credentials have been disclosed publicly, ensure you change the db authentication details

examples/dash/dash-connect-pgsql/Dockerfile Outdated Show resolved Hide resolved
examples/dash/dash-connect-pgsql/Dockerfile Outdated Show resolved Hide resolved
examples/dash/dash-connect-pgsql/README.md Outdated Show resolved Hide resolved
examples/dash/dash-connect-pgsql/app.py Outdated Show resolved Hide resolved
examples/dash/dash-connect-pgsql/upload.py Show resolved Hide resolved
Added more detailed steps on how to upload dataset and configure secret variables in README
@edublancas
Copy link
Contributor

@bryannho please help me checking the comments from my existing review and approve if you think it's good to go now

@neelasha23
Copy link
Contributor

neelasha23 commented Jul 29, 2024

Please try deploying the app using the Dash framework instead of Docker. Once you get it working u can remove the Dockerfile. Also, do share the new app link @bchen39

bqd39 added 2 commits July 29, 2024 11:25
Additionally: removed Dockerfile and removed extra package from requirements.txt
@bchen39
Copy link
Contributor Author

bchen39 commented Jul 29, 2024

Please try deploying the app using the Dash framework instead of Docker. Once you get it working u can remove the Dockerfile. Also, do share the new app link @bchen39

@neelasha23 link to app

@neelasha23
Copy link
Contributor

Is this ready for review? @bchen39

@bchen39 bchen39 requested a review from neelasha23 July 29, 2024 15:42
neelasha23
neelasha23 previously approved these changes Jul 29, 2024
@bchen39 bchen39 requested a review from neelasha23 July 29, 2024 17:03
Copy link
Contributor

@neelasha23 neelasha23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few more comments

Copy link
Contributor

@bryannho bryannho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one minor comment

examples/dash/dash-connect-pgsql/data/csv_mod.py Outdated Show resolved Hide resolved
@bryannho bryannho dismissed stale reviews from edublancas and neelasha23 July 29, 2024 22:32

dismissing to merge

@bryannho bryannho merged commit 59a76f0 into main Jul 29, 2024
1 check passed
@bryannho bryannho deleted the dash-connect-pgsql branch July 29, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants