Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[analytics] Adding Posthog logs #275

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Conversation

LatentDream
Copy link
Member

@LatentDream LatentDream commented Sep 3, 2024

Changes

  • Added Posthog logging on Docs

Notes

I've look to modify the build system to inject the key at build time with a env. var., but Jupyter-book is a wrapper for Sphink. It would have been "doable" if we were using Sphink directly, but it doesn't seems possible with jupyter-book alone. I've try some work around, and I couldn't figure out a way.

  • Not worth using Shink since everything is done with jupyter-book
  • The posthog key is a public key. (Sent to all client. Is written in clear in the html for people to see)
  • The key for Google analytics (equivalent to the Posthog) key is also written in clear in this repo. I guess it's because of the same reason.

Close #274


📚 Documentation preview 📚: https://ploomber-doc--275.org.readthedocs.build/en/275/

@edublancas edublancas merged commit 81637f1 into main Sep 4, 2024
2 checks passed
@edublancas edublancas deleted the 274-analytics-add-posthog branch September 4, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Analytics] Add Posthog
2 participants