Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document deploy --watch #56

Merged
merged 5 commits into from
Dec 15, 2023
Merged

Conversation

bryannho
Copy link
Contributor

@bryannho bryannho commented Dec 14, 2023

Closes #55

  • Added description and instruction for deploy --watch in cli.md
  • Updated instructions in github.md to include --watch in the ploomber-cloud.yaml file by default. Included description of how to remove it, and how that would change the behavior.
  • Will open a PR to add --watch to the ploomber-cloud template
  • I haven't updated the image of the logs in the github actions guide but I can. Let me know if I should do that.

📚 Documentation preview 📚: https://ploomber-doc--56.org.readthedocs.build/en/56/

@bryannho bryannho marked this pull request as ready for review December 14, 2023 21:11
@bryannho bryannho requested a review from edublancas as a code owner December 14, 2023 21:11
@bryannho bryannho requested review from edublancas and removed request for edublancas December 14, 2023 21:11
Copy link
Contributor

@edublancas edublancas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update the image , we can keep the version without --watch and include one that shows how the logs look like when passing --watch

@bryannho bryannho requested a review from edublancas December 15, 2023 00:51
@bryannho
Copy link
Contributor Author

please update the image , we can keep the version without --watch and include one that shows how the logs look like when passing --watch

@edublancas replaced the image here. i put the version with --watch first because it's in the sample yaml by default, then after it i put the version without --watch

@edublancas edublancas merged commit 2f15e61 into ploomber:main Dec 15, 2023
1 check passed
@bryannho bryannho deleted the 55-deploy-watch branch December 15, 2023 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

document --watch
2 participants