Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom DNS pointing method added #65

Merged
merged 5 commits into from
Jan 16, 2024
Merged

Custom DNS pointing method added #65

merged 5 commits into from
Jan 16, 2024

Conversation

yafimvo
Copy link
Contributor

@yafimvo yafimvo commented Jan 16, 2024

Documents how to add another way to register a custom domain by setting CNAME and Alias records


📚 Documentation preview 📚: https://ploomber-doc--65.org.readthedocs.build/en/65/

@yafimvo yafimvo requested a review from edublancas as a code owner January 16, 2024 11:05
idomic
idomic previously approved these changes Jan 16, 2024
Copy link
Contributor

@idomic idomic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few typos, looks good.

doc/user-guide/custom-domains.md Outdated Show resolved Hide resolved
doc/user-guide/custom-domains.md Outdated Show resolved Hide resolved
doc/user-guide/custom-domains.md Outdated Show resolved Hide resolved
doc/user-guide/custom-domains.md Outdated Show resolved Hide resolved
@idomic idomic merged commit 8d1700d into main Jan 16, 2024
1 check passed
@idomic idomic deleted the custom_dns_pointing_method branch January 16, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants