Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename dashboard -> application #68

Merged
merged 7 commits into from
Jan 18, 2024
Merged

rename dashboard -> application #68

merged 7 commits into from
Jan 18, 2024

Conversation

tonykploomber
Copy link
Contributor

@tonykploomber tonykploomber commented Jan 17, 2024 •
edited by edublancas
Loading

Rename dashboard -> application

Including text, image

closes #67

📚 Documentation preview 📚: https://ploomber-doc--68.org.readthedocs.build/en/68/

@tonykploomber tonykploomber linked an issue Jan 17, 2024 that may be closed by this pull request
Rename dashboard -> application #67
Closed
@tonykploomber tonykploomber marked this pull request as ready for review January 17, 2024 04:43
neelasha23
neelasha23 reviewed Jan 17, 2024
View reviewed changes
doc/apps/voila.md Outdated Show resolved Hide resolved
@neelasha23
Copy link
Contributor

neelasha23 commented Jan 17, 2024 •
edited
Loading

  1. There are some mentions of dashboard in user-guide/github.md
  2. doc/static/copy-api-key.png In this image inputs should be
  3. doc/static/web-home.png : The latest homepage has labels, type etc which is missing from this image

@tonykploomber

yafimvo
yafimvo requested changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@yafimvo yafimvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg. We just need to update this image as well

@tonykploomber
Copy link
Contributor Author

lg. We just need to update this image as well

Would you give me the file name of image? Not sure which one you are referring to

@tonykploomber
Copy link
Contributor Author

tonykploomber commented Jan 17, 2024 •
edited by neelasha23
Loading

There are some mentions of dashboard in user-guide/github.md
doc/static/copy-api-key.png In this image inputs should be
doc/static/web-home.png : The latest homepage has labels, type etc which is missing from this image
@tonykploomber

Updated in dashboard
Not sure what you meant, but I masked the api key and email in the image
Updated
update image

bryannho
bryannho reviewed Jan 18, 2024
View reviewed changes
Copy link
Contributor

@bryannho bryannho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg.

Would you give me the file name of image? Not sure which one you are referring to

I believe its /doc/static/env-vars/env-vars-section.png
@tonykploomber

@neelasha23
Copy link
Contributor

Not sure what you meant, but I masked the api key and email in the image

I meant in the previous version there was a black bar on the inputs to hide the values. @tonykploomber

neelasha23
neelasha23 previously approved these changes Jan 18, 2024
View reviewed changes
@yafimvo
Copy link
Contributor

yafimvo commented Jan 18, 2024

Would you give me the file name of image? Not sure which one you are referring to

It's this one
https://ploomber-doc--68.org.readthedocs.build/en/68/user-guide/env-vars.html

@tonykploomber
Copy link
Contributor Author

Not sure what you meant, but I masked the api key and email in the image

I meant in the previous version there was a black bar on the inputs to hide the values. @tonykploomber

Yes it's masked now

@tonykploomber
Copy link
Contributor Author

Would you give me the file name of image? Not sure which one you are referring to

It's this one https://ploomber-doc--68.org.readthedocs.build/en/68/user-guide/env-vars.html

update doc

@edublancas
Copy link
Contributor

@neelasha23 @yafimvo @bryannho please review again and approve if all looks good

@idomic idomic merged commit 0831cab into main Jan 18, 2024
1 check passed
@idomic idomic deleted the 67-rename-dashboard-application branch January 18, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yafimvo yafimvo yafimvo approved these changes

@bryannho bryannho bryannho approved these changes

@neelasha23 neelasha23 neelasha23 left review comments

@edublancas edublancas Awaiting requested review from edublancas edublancas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename dashboard -> application
6 participants
@tonykploomber @neelasha23 @yafimvo @edublancas @bryannho @idomic