- fix bug: node_modules lookup may fall into endless loop and halt…

… the program. - bump version
plotdb · Dec 16, 2022 · 666a9c1 · 666a9c1
1 parent 7c9b036
commit 666a9c1
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,8 +1,13 @@
 # Change Logs
 
+## v1.1.9
+
+ - fix bug: `node_modules` lookup may fall into endless loop and halt the program.
+
+
 ## v1.1.8
 
- - support modules from parent `node_modeuls`
+ - support modules from parent `node_modules`
 
 
 ## v1.1.7

diff --git a/cli.js b/cli.js
@@ -75,9 +75,9 @@ cmds['default'] = {
         root = localModule.path;
       } else {
         base = '.';
-        while (root !== '/') {
+        while (path.resolve(base) !== '/') {
           root = path.resolve(path.join(base, 'node_modules', obj.name));
-          if (fs.existsSync(root)) {
+          if (fs.existsSync(path.join(root, 'package.json'))) {
             break;
           }
           base = path.join(base, '..');

diff --git a/lib/main.ls b/lib/main.ls
@@ -43,9 +43,9 @@ cmds.default =
       if local-module => root = local-module.path
       else
         base = '.'
-        while root != \/
+        while path.resolve(base) != \/
           root = path.resolve(path.join base, \node_modules, obj.name)
-          if fs.exists-sync(root) => break
+          if fs.exists-sync(path.join(root, \package.json)) => break
           base = path.join(base, \..)
 
       info = JSON.parse(fs.read-file-sync path.join(root, "package.json") .toString!)

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -6,7 +6,7 @@
     "cli.js"
   ],
   "description": "Frontend dependency installer",
-  "version": "1.1.8",
+  "version": "1.1.9",
   "homepage": "https://github.com/plotdb/fedep",
   "repository": {
     "type": "git",