-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
dcc redesign: DatePickerSingle and DatePickerRange
#3495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v4
Are you sure you want to change the base?
Conversation
b2d62da to
de88f2b
Compare
de88f2b to
75fd1fe
Compare
|
Wow! First look at this is amazing 🤩 I love how you can easily skip months and years - that's been a pain point in the old date pickers for a long time. This is an incredible amount of work given that the Radix components does not have date pickers and you had to build all of this from scratch. I see you are still using moment.js for the date formatting. Since they are no longer recommending moment.js to be used in new project, would you consider using one of their recommended alternatives? It might make it easier to add support for locale at some point https://momentjs.com/docs/#/-project-status/ |
|
Thanks @AnnMarieW ! And wow, I did not realize moment was fading away like that! I will take a look at replacing moment - it shouldn't be too much effort there.
|
At long last, here is a PR to modernize the date pickers.
You can play with them here:
https://dcc-redesign.plotly.app/datepickers-single
https://dcc-redesign.plotly.app/datepickers-range
Some improvements:
dcc.Dropdown's look and feel