Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional import for psutil #4868

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Add optional import for psutil #4868

merged 1 commit into from
Nov 12, 2024

Conversation

marthacryan
Copy link
Collaborator

Fixes #4867.

@marthacryan marthacryan changed the title Fix psutil import error Add optional import error for psutil Nov 12, 2024
@marthacryan marthacryan changed the title Add optional import error for psutil Add optional import for psutil Nov 12, 2024
@marthacryan marthacryan requested a review from emilykl November 12, 2024 22:44
@marthacryan
Copy link
Collaborator Author

@emilykl tagged you for review on this because you found the issue - let me know if this fixed it for you! It fixed it for me.

emilykl
emilykl approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@emilykl emilykl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in the same env that was failing before, works! 🚀

I guess if psutil is not installed somehow in a Jupyter environment it will simply not show the warning, which seems fine.

@marthacryan marthacryan merged commit d31c728 into master Nov 12, 2024
5 checks passed
@marthacryan marthacryan deleted the psutil-err branch January 28, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilykl emilykl emilykl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ModuleNotFoundError: No module named 'psutil'
2 participants
@marthacryan @emilykl