Update version of plotly.js to 3.0.0-rc.0 #4871
Merged
+957
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
Earlier today, @archmoj merged #4860 and updated
plotly.jsto3.0.0-rc.0, but in #4823 I changed the source of theplotly.jsversion, so it didn't pick up the newplotly.jsversion. This means that when you runpython setup.py updateplotlyjsin the currentmasterbranch, all of the code generated is representing plotly.js version2.35.2.The solution
This is just adding updating the version of
plotly.jsto3.0.0-rc.0in the new location (which is documented in thecontributing.md).Testing
If you run
python setup.py updateplotlyjs, then rungit status, there shouldn't be any changes.